tls: Typesafe tls slots #13789
Merged
tls: Typesafe tls slots #13789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
commented
Oct 28, 2020
There was a problem hiding this comment.
@mattklein123 ptal -- this is not ready to go yet -- needs unit tests and covering the other existing dynamically typed uses of Tls::SlotPtr, but I wanted to see if you liked the pattern before I use it everywhere.
akonradi
reviewed
Oct 28, 2020
mattklein123
requested changes
Oct 28, 2020
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
|
Thanks in general this LGTM. Do you want to do all sites? Or just land this first and then do some further PRs? /wait |
|
I think I'll try to get this in first and then iterate on the rest of the sites. But first I want to survey the existing sites to see if there's any gap in usage. In particular I am interested in cases where we are returning a new value from the runOnAllThreads lambda. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
requested changes
Oct 28, 2020
…us misc comments. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
Oct 29, 2020
akonradi
reviewed
Oct 29, 2020
|
/retest |
|
Retrying Azure Pipelines: |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 30, 2020
* master: (83 commits) tls: Typesafe tls slots (envoyproxy#13789) docs(example): Correct URL for caching example page (envoyproxy#13810) [fuzz] Made health check fuzz more efficient (envoyproxy#13747) rtds: properly scope rtds stats (envoyproxy#13764) http: fixing a bug with IPv6 hosts (envoyproxy#13798) connection: Remember transport socket read resumption requests and replay them when re-enabling read. (envoyproxy#13772) network: adding some accessors for ALPN work. (envoyproxy#13785) docs: added a step about how to handle platform specific extensions (envoyproxy#13759) Fix identation in ip transparency code snippet (envoyproxy#13743) wasm: enable WAVM's stack unwinding feature (envoyproxy#13792) log: set route name for direct response (envoyproxy#13683) Use nghttp2 as external dependsncy in protocol_constraints_lib (envoyproxy#13763) [Windows] Update windows dev docs (envoyproxy#13741) cel: patch thread safety issue (envoyproxy#13739) Windows: Fix ssl_socket_test (envoyproxy#13264) apple dns: add fake api test suite (envoyproxy#13780) overload: scale selected timers in response to load (envoyproxy#13475) examples: Add dynamic configuration (control plane) sandbox (envoyproxy#13746) Removed exception in getResponseStatus() (envoyproxy#13314) network: add timeout for transport connect (envoyproxy#13610) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Adds a new
TypedSlotAPI, where the slot data is strongly typed. Also removes an unused capability to replace slot data with a new instance via the callbacks inrunOnAllThreads.Use this new API rather than the untyped
SlotAPI for one of the sites (stats thread_local_store.cc).This is a partial fix for #13313
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a